Fix CSS validation errors and patch shell-quote CVE#112
Merged
Conversation
The var(--swiffy-slider-item-ratio) padding-top calc() had a redundant wrapping parenthesis, and the .slider-nav::after mask shorthand combined with mask-size: cover minified into a background-position/size form the W3C CSS Validator rejects. Split into longhand mask-image/mask-size and removed the extra parens. Fixes #111 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
concurrently@9.0.0 pulled in shell-quote@1.8.3, flagged as critical severity. concurrently@9.2.4 depends on shell-quote@1.9.0, resolving the advisory while staying on Node >=18 (no major bump needed). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padding-top: calc()ratio hack and splits the.slider-nav::aftermaskshorthand intomask-image/mask-sizelonghands, so the built CSS no longer emits values the W3C CSS Validator rejects (calc( 100% / (var(...))))and a combinedmask: url(...) 0 0/cover)concurrentlydevDependency from^9.0.0to^9.2.4to pull in patchedshell-quote@1.9.0, resolving CVE-2026-9277 (critical) flagged by Dependabot; no Node engine bump requiredTest plan
npm run buildcompletes cleanly and dist/docs assets regenerated.slider-nav:afterrule no longer collapses intomask: url(...) 0 0/covershorthandpadding-topno longer has the extra wrapping parenthesisnpm auditreports 0 vulnerabilities after the concurrently bump