Fold demo-build learning: derive the scrub token list in-session, retire scrub-list.txt#59
Merged
Merged
Conversation
…ire scrub-list.txt The sanitize gate's grep pack read its engagement tokens from an external per-engagement scrub-list file that repeatedly failed in practice: the documented location resolved to an unwritable path, so folds stalled on "scrub list not found" instead of scrubbing. The file was also redundant — every token that could leak into a fold is present in the material being folded, so the list can be enumerated in-conversation each time. iterate-plugin.md Step 1a now specifies the in-session enumeration (brands incl. misspellings/slugs, hostnames, personas/accounts, engagement domain vocabulary, demo-minted ids) plus a mandatory adversarial re-read of the staged diff to catch non-generic wording the enumeration missed. The "when to expand the known-names list" section and the final pre-commit grep's file read are removed; the constant time/path packs are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sanitize gate read its engagement tokens from an external per-engagement
scrub-list.txt. That mechanism failed recurringly in practice: the documented location ($DYNAMICWEB_SKILLS_REPO\..\..\scrub-list.txt) resolves to an unwritable path on a standard clone layout, so folds stalled on "scrub list not found" instead of scrubbing — and the file itself was redundant, since every token that could leak into a fold is by construction present in the material being folded.Changes to
dw-demo-base/references/iterate-plugin.md:Get-Contentin the final pre-commit grep.Version 4.10.0 (4.9.0 is claimed by the in-flight #58; entries are independent — whichever merges second takes a trivial CHANGELOG/version rebase).
Gates:
validate-skills.pyexit 0; in-session scrub pack over the staged diff — 0 name hits, 1 time hit which is the doc's own pattern-definition line.