Fold demo-build learnings: theme staging gate, MCP silent no-op catalogue, PLP list/thumbnail levers, bootstrap conventions#56
Merged
Conversation
…ogue, PLP list/thumbnail levers, bootstrap conventions A 2026-07 UI pass across two local demo hosts found both had shipped with the Style-asset empty-state (Areas wired to swift/buttons/fonts ids the Swift repo never ships files for) rendering serif-fallback storefronts that looked "almost right" since build day. The same pass caught delete_area/delete_users/ delete_paragraphs and build_product_index reporting success without acting, and update_users dropping an undocumented password property. deserialize-flow gains a mandatory theme-staging step, integrity-sweep gains Check 8 (style assets + designed-screenshot gate), visual-qa's definition of done gains the theme gate, extend-mcp-tools 5 extends the silent no-op catalogue, swift-building 3 gains the PLP list-layout/thumbnail-width rows, and scaffold 3 standardizes the local demo admin login and the Standard-area (AreaId 1) removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 2026-07 UI pass across two local demo hosts found both had shipped with the Style-asset empty-state (Areas wired to swift/buttons/fonts ids the Swift repo never ships files for), rendering serif-fallback storefronts that looked "almost right" since build day. The same pass caught several MCP tools reporting success without acting.
Changes
dw-demo-swift/references/deserialize-flow.md— new mandatory "Stage the theme's Style assets" step in the design-package deploy: the Swift clone lands onlyColorScheme.config, so theme-default's three pairs must be staged and the Areas rewired, verified by the three emitted style links.dw-demo-swift/references/integrity-sweep.md— new Check 8 (theme gate): files-match-Area-wiring probe + emitted-links probe + the designed-full-page-screenshot requirement. Sweep is now eight checks.dw-demo-base/references/visual-qa.md— theme gate added to the definition of done (serif-fallback pages fail even when they render without errors).dw-demo-base/references/scaffold.md— bootstrap conventions: local demo-host admin login standardized (Admin/Admin1, hosted installs keep real secrets) and the wizard-seeded Standard area (AreaId 1) is deleted via SQL before scaffold counts as done.foundational/extend-mcp-tools.md§5 +surface-priority.md— silent no-op catalogue extended to deletes and builds:delete_area/delete_users/delete_paragraphsreturnsucceeded:1and delete nothing;build_product_indexreports a completed build while touching only theLastUpdatedmarker (Admin UI Repositories -> Build Full is the working path; verify by shard-file mtimes);update_usersaccepts and drops apasswordproperty.foundational/swift-building.md§3 — PLP truths: the surface-serialized shop repeater shipsGridLayoutDesktop='list'(list IS the intended layout — keep it); the full-bleed-image failure mode is the card image item'sWidth='auto'(px value = thumbnail lever); plus theShowAlternativeImageOnHoverNRE on products without aDefaultImage.Validator exit 0; sanitization grep pack zero hits across diff and message.