Use wide char aware hstr_strlen() for promptLength
#533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate length of prompt correctly if `HSTR_PROMPT` contains UTF-8 characters (e.g. `'❯ '`)
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the prompt length calculation to correctly handle UTF-8 characters by replacing the call to strlen() with the wide char aware hstr_strlen() function.
- Replaces the call to strlen() with hstr_strlen() in the prompt printing logic.
- Ensures that prompts containing UTF-8 characters, such as "❯ ", are measured correctly for proper display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate length of prompt correctly if
HSTR_PROMPTcontains UTF-8 characters (e.g.'❯ ')