fix: Remove unwanted trailing slash when resolving href in hash mode #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In browser extension environments, when using hash mode, resolveNewHref() was appending a trailing slash which gives a "Youre file couldn't be accessed" error when the user directly enters that href in the url bar. Removing the trailing slash fixes that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hash mode,
resolveNewHref()adds a trailing slash to the URL's pathname to avoid ambiguity between path segments and query strings like this:chrome-extension://<ext_id>/popup.html/#/settings-pageBut in Chrome extensions—where resources like
popup.htmllive under thechrome-extension://protocol—a trailing slash in the pathname causes Chrome to treat it as a request for a directory rather than a file, when the user inputs this URL directly in their address bar. This shows them a "Your file couldn't be accessed" error.We need to instead resolve it to this:
chrome-extension://<ext_id>/popup.html#/settings-pageWhen a user directly inputs this in their address bar, the browser correctly opens the
popup.htmlfile and the router correctly routes us to the/settings-pageas expected.