Allow custom user agent specification#18
Merged
AaronAtDuo merged 1 commit intoduosecurity:mainfrom Aug 12, 2025
Merged
Conversation
AaronAtDuo
requested changes
Aug 11, 2025
8d8f3ad to
247250d
Compare
247250d to
74c3f9b
Compare
AaronAtDuo
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for extension of user agent strings. Users can now extend a user agent via appendToUserAgent() method of Client class.
Motivation and Context
This change was specifically requested to allow
duo_universal_wordpress(the WordPress plugin) to specify its own user agent when making requests to Duo's servers.How Has This Been Tested?
testAppendToUserAgent()- verifies that the user agent extension can be set and is included in requeststestUserAgentWithoutExtension()- verifies that user agent works correctly without any extensiontestAppendToUserAgentEmpty()- verifies that empty user agent extension is handled correctlyTypes of Changes