Skip to content

Docs: Work with content-scope-scripts repo on Windows #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2025

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Jul 4, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201614831475344/task/1210717003881747?focus=true

Description

Move content from: Work with content-scope-scripts repo on Windows

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 8c955ca
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/686c42db6322290008ecca80
😎 Deploy Preview https://deploy-preview-1794--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jul 4, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@jonathanKingston jonathanKingston changed the title Jkt/getting started Docs: Work with content-scope-scripts repo on Windows Jul 4, 2025
Copy link

github-actions bot commented Jul 4, 2025

[Beta] Generated file diff

Time updated: Mon, 07 Jul 2025 21:58:42 GMT

@jonathanKingston jonathanKingston marked this pull request as ready for review July 4, 2025 20:02
@jonathanKingston jonathanKingston requested review from a team, shakyShane and mgurgel as code owners July 4, 2025 20:02
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind having a 'recommendation' for WSL, but I wouldn't want us to get closer to codebases like the extension where the continued use of bash has made it difficult for FE/JS folks to contribute to. Node is cross-platform by default and we should lean on it IMO - that's how you make contribution on Windows easier. Requiring WSL is the opposite, it's a more complicated contribution path :) Maybe we just change the wording or something to indicate 'you might prefer WSL' and not 'you can only build with WSL'?

@jonathanKingston
Copy link
Contributor Author

mmendation' for WSL, but I wouldn't want us to get closer to codebases like the extension where the continued use of bash has made it difficult for FE/JS folks to contribute to. Node is cross-platform by default and we should lean on it IMO - that's how you make contribution on Windows easier. Requiring WSL is the opposite, it's a more complicated contribution path :) Maybe we just change the wording or something to indicate 'you might prefer WSL' and not 'you can only build with WSL'?

Yeah happy to make this change, BTW I think the Windows devs wrote this: https://app.asana.com/1/137249556945/project/1201614831475344/task/1203837324583081?focus=true

@jonathanKingston
Copy link
Contributor Author

@shakyShane OK I've made it a suggestion along with the other bits. I think this sort of highlights orphaned docs like this in Asana and how outdated they get. I think some of the other advice is worth having anyway.

My view is we can continue to iterate here and AI tools are likely to find silliness faster too.

@jonathanKingston jonathanKingston merged commit 9b055be into main Jul 7, 2025
15 checks passed
@jonathanKingston jonathanKingston deleted the jkt/gettingStarted branch July 7, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants