[in progress] scriptlets as an npm module #1757
Conversation
❌ Deploy Preview for content-scope-scripts failed.
|
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 19 Jun 2025 15:23:39 GMT IntegrationFile has changed AppleFile has changed |
|
|
||
| const test = testContextForExtension(base); | ||
|
|
||
| test.describe('Scriptlets Integration Tests', () => { |
There was a problem hiding this comment.
Is all this a dupe of the test-pages stuff? I see a lot of waitForTimeout too which is pretty flakey.
There was a problem hiding this comment.
I see it's supposed to be testing them. it seems a lot more involved than the intent here. Can you ask it to make this file more like injected/integration-test/pages.spec.js where there's no state where possible this will make most of them work in privacy-test-pages.site without having special setup code?
I also don't see it using the config in automation? Perhaps I've misread?
There was a problem hiding this comment.
| @@ -13,13 +13,13 @@ | |||
| <p>This page verifies that the remove-node-text scriptlet works properly given the <a href="../config/remove-node-text.json">config</a>.</p> | |||
|
|
|||
| <!-- This script should have its content removed because it contains "badScriptContent" --> | |||
There was a problem hiding this comment.
Should this test just be checking for regular div text change removal? Given the abort inline script it seems a little misleading as a test?
Asana Task/Github Issue:
Description
Testing Steps
Checklist
Please tick all that apply: