Update Input Screen landscape behavior

[joshliebe]

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211507598155413?focus=true

Description

• Uses top omnibar behavior when in landscape and using bottom address bar

Steps to test this PR

• Set the address bar to “Bottom"
• Open the Input Screen and type something (so that the input expands)
• Rotate to landscape
• Verify that the top omnibar behavior is used

UI changes

Before	After

[joshliebe]

• Update Input Screen landscape behavior #6898 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[LukasPaczos]

Works as expected 👍

A minor change I would make is to use a slide transition instead of fade transition when going from bottom omnibar to top input screen bar, I think it feels better. This would require adding isLandscape to BrowserAndInputScreenTransitionProvider (or passing some activity context) and I'd understand if you don't want to do it here. We can revisit whenever we touch this code next time.

[LukasPaczos]

Suggested change

	override fun useTopBar(isLandscape: Boolean): Boolean =
	useTopBar(
	isTopOmnibar = isTopOmnibar,
	isTopOmnibar = isTopOmnibar || isLandscape,
	duckChatInternal = duckChatInternal,
	)
	override fun useTopBar(isLandscape: Boolean): Boolean =
	useTopBar(
	isTopOmnibar = isTopOmnibar,
	duckChatInternal = duckChatInternal,
	) || isLandscape

This is a little clearer in intent to me.

[LukasPaczos]

Ah sorry, now noticing that other invocations of useTopBar are not providing the orientation. This results in missing blur and autocomplete recycler offset (which in this context debatable because buttons are to the side), but also the autocomplete arrows point in the wrong direction.

[LukasPaczos]

To cover all the cases, you can leverage the new activity context injection into InputScreenConfigResolverImpl, because it's already tied to the ActivityScope:

@Inject
@ActivityContext
lateinit var activityContext: Context

and do:

override fun useTopBar(): Boolean =
    useTopBar(
        isTopOmnibar = isTopOmnibar,
        duckChatInternal = duckChatInternal,
    ) || activityContext.resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE