-
Notifications
You must be signed in to change notification settings - Fork 1.1k
UI for bookmarks import flow #6836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
UI for bookmarks import flow #6836
Conversation
a039a47
to
3f8950c
Compare
b3fac77
to
a14e381
Compare
77c3176
to
791ae21
Compare
1713a4f
to
cb2b5cb
Compare
4614087
to
9f3b412
Compare
cb2b5cb
to
bde236b
Compare
9f3b412
to
17a6c44
Compare
bde236b
to
dfbcd8e
Compare
17a6c44
to
e890ed7
Compare
7f7ff4b
to
2e9a36c
Compare
e890ed7
to
b217c11
Compare
2e9a36c
to
7ac6dca
Compare
0003be7
to
a714667
Compare
7ac6dca
to
49ab43d
Compare
a714667
to
a8e4b48
Compare
566d0e5
to
2575f8d
Compare
a8e4b48
to
8393d44
Compare
2575f8d
to
ad5d7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements the UI flow for importing bookmarks (pre‑import prompt, automated web flow progress overlay, success/error result screens) and wires it into internal dev settings plus supporting view models, navigation params, and tests.
- Adds pre-import dialog, progress overlay, success/failure result fragments, and related string/drawable resources.
- Updates web flow ViewModel/Fragment/Activity logic (page visibility handling, cancellation confirmation, result handling, new launch sources).
- Extends tests and API enums to support bookmark import launch sources.
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 9 comments.
Show a summary per file
File | Description |
---|---|
autofill-internal/src/main/res/values/donottranslate.xml | Added string for new pre-import dialog launch entry. |
autofill-internal/src/main/res/layout/activity_autofill_internal_settings.xml | Added dev settings entries for new bookmark import flows and simulated result screens. |
AutofillInternalSettingsActivity.kt | Integrated pre-import dialog, result handling, and success/error simulation launchers. |
ImportGoogleBookmarksWebFlowViewModelTest.kt | Added tests for URL handling visibility logic and revised back navigation behavior. |
autofill-impl/src/main/res/values/donottranslate.xml | Added comprehensive bookmark import UI strings (pre-import, progress, success, error). |
fragment_import_bookmarks_result.xml | New success/error result UI layout. |
fragment_import_bookmarks_progress.xml | New automation progress overlay layout. |
content_import_bookmarks_from_google_success_state.xml | Success state content layout. |
content_import_bookmarks_from_google_preimport_dialog.xml | Pre-import dialog layout. |
info_24.xml | New vector drawable (info icon). |
bookmarks_import_128.xml | New vector drawable (bookmark import artwork). |
ImportPasswordsPixelSender.kt | Formatting/parameter layout adjustments. |
ImportFromGoogleBookmarksPreImportDialogViewModel.kt | New ViewModel scaffolding (states for pre-import / success / error). |
ImportFromGoogleBookmarksPreImportDialog.kt | New pre-import bottom sheet dialog. |
ImportGoogleBookmarksWebFlowViewModel.kt | Added page visibility logic & cancellation prompt command. |
ImportGoogleBookmarksWebFlowFragment.kt | Added progress overlay communication, cancellation confirmation, and result emission adjustments. |
ImportGoogleBookmarksWebFlowActivity.kt | Orchestrates web flow, progress overlay, and result fragments; adds result activity params. |
ImportGoogleBookmarksAutomationInProgressViewFragment.kt | Progress overlay fragment. |
ImportGoogleBookmarkResult.kt | Added Unknown reason and parcelization adjustments. |
ImportFinishedFragment.kt | Result (success/error) fragment implementation. |
AutofillCredentialDialogs.kt | Added AutofillImportBookmarksLaunchSource enum & minor formatting. |
autofill/autofill-internal/src/main/res/layout/activity_autofill_internal_settings.xml
Outdated
Show resolved
Hide resolved
autofill/autofill-internal/src/main/res/layout/activity_autofill_internal_settings.xml
Outdated
Show resolved
Hide resolved
...agement/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...agement/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt
Outdated
Show resolved
Hide resolved
...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowFragment.kt
Outdated
Show resolved
Hide resolved
autofill/autofill-impl/src/main/res/layout/fragment_import_bookmarks_result.xml
Outdated
Show resolved
Hide resolved
.../autofill-impl/src/main/res/layout/content_import_bookmarks_from_google_preimport_dialog.xml
Show resolved
Hide resolved
14c617a
to
39a6424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
autofill/autofill-impl/src/main/res/values/donottranslate.xml:1
- Label 'Cancel' for the destructive action can be ambiguous alongside 'Continue'; consider changing it to 'Cancel Import' to make the consequence explicit.
<?xml version="1.0" encoding="utf-8"?><!--
...in/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarkResult.kt
Outdated
Show resolved
Hide resolved
...ntial/management/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialog.kt
Outdated
Show resolved
Hide resolved
...ntial/management/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialog.kt
Outdated
Show resolved
Hide resolved
...ntial/management/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialog.kt
Outdated
Show resolved
Hide resolved
...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt
Show resolved
Hide resolved
289bf6e
to
4d28998
Compare
f942c31
to
d2f84e9
Compare
d2f84e9
to
2e82169
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211407036705134?focus=true
Description
Adds UI to the bookmarks import flow, as well as a few more options in internal dev settings for testing them.
Autofill Dev Settings
screen (i.e., doesn't allow for flow to start in production)Steps to test this PR
Bookmark-import
internal
build typePre-import dialog
Autofill Dev Settings
, tap onLaunch Bookmarks import flow (with preimport dialog)
Import Now
and verify it launches the web flowWeb Flow, cancellations
Carrying on from the previous test
Cancel Import
Import Now
again, and this time use the back button, confirming you see the cancellation confirmation promptWeb flow, from a logged out state
You should not be logged in to a Google account already (which should be true if you're following these steps)
Web flow, from a signed in state
You should be logged in already to a Google account
WebView
, and instead jump straight to the in-progress flowWeb flow, dev-only peeking at the WebView