Skip to content

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Sep 9, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200905986587319/task/1211302374656672?focus=true

Description

Moved widget-related strings from donottranslate.xml to strings.xml and added translation instructions to make them available for localization.

Steps to test this PR

No QA.

NO UI changes

Copy link
Contributor Author

anikiki commented Sep 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki marked this pull request as ready for review September 9, 2025 16:24
@anikiki anikiki requested a review from Copilot September 9, 2025 16:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves widget-related strings from the non-translatable resource file to the translatable strings file to enable localization support for widget labels and descriptions.

  • Moved 5 widget-related string resources from donottranslate.xml to strings.xml
  • Added translation instructions for each moved string to guide localization teams

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
app/src/main/res/values/strings.xml Added 5 widget strings with translation instructions
app/src/main/res/values/donottranslate.xml Removed the same 5 widget strings and their comment section

Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anikiki anikiki merged commit e17d88a into develop Sep 12, 2025
12 checks passed
@anikiki anikiki deleted the feature/ana/widget_translations_l10n branch September 12, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants