-
Notifications
You must be signed in to change notification settings - Fork 998
Refresh sync settings screen automatically #5773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh sync settings screen automatically #5773
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
96b144a
to
8a953b6
Compare
11c24a9
to
674f8d2
Compare
8a953b6
to
ceb1f46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested also a related additional scenario: remotely remove a device, and wait on the second device to be disconnected. It worked as expected 👍
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/ui/SyncActivityViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
ceb1f46
to
7348ea6
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1209669301264637
Description
Allows the sync settings screen to automatically refresh while it is being viewed. This is in part to provide a better UX to #5762.
Steps to test this PR
sync / automaticallyUpdateSyncSettings
feature flag and return to the sync settings screen. Repeat the above test and verify the other device doesn’t automatically update since background refreshing is disabled (i.e., fallback to original behaviour when flag disabled)