Skip to content

Refresh sync settings screen automatically #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Mar 13, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1209669301264637

Description

Allows the sync settings screen to automatically refresh while it is being viewed. This is in part to provide a better UX to #5762.

Steps to test this PR

  • Enter sync settings with sync disabled. Verify everything looks as expected and there is no visual updates to the UI
  • Enable sync. Verify everything looks as expected and there is no visual updates to the UI.
  • Sync with another device, such that you can see two devices in this view; your device, plus one other
  • On the other device, turn off sync
  • Back on the first device, verify it updates within the next 5s to show the other device is now gone
  • Disable sync / automaticallyUpdateSyncSettings feature flag and return to the sync settings screen. Repeat the above test and verify the other device doesn’t automatically update since background refreshing is disabled (i.e., fallback to original behaviour when flag disabled)
  • Smoke test any other related sync scenarios you think might be problematic because of this

Copy link
Member Author

CDRussell commented Mar 13, 2025

@CDRussell CDRussell changed the title Add support for refreshing sync settings screen automatically Refresh sync settings screen automatically Mar 13, 2025
@CDRussell CDRussell force-pushed the feature/craig/automatically_refreshing_sync_activity branch from 96b144a to 8a953b6 Compare March 13, 2025 14:23
@CDRussell CDRussell changed the base branch from feature/cristian/sync/align_recovery_with_connect_flow to graphite-base/5773 March 13, 2025 14:36
@CDRussell CDRussell force-pushed the graphite-base/5773 branch from 11c24a9 to 674f8d2 Compare March 13, 2025 14:36
@CDRussell CDRussell force-pushed the feature/craig/automatically_refreshing_sync_activity branch from 8a953b6 to ceb1f46 Compare March 13, 2025 14:36
@CDRussell CDRussell changed the base branch from graphite-base/5773 to develop March 13, 2025 14:36
@CDRussell CDRussell marked this pull request as ready for review March 13, 2025 14:49
@cmonfortep cmonfortep requested a review from Copilot March 17, 2025 08:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@cmonfortep cmonfortep self-requested a review March 17, 2025 08:52
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested also a related additional scenario: remotely remove a device, and wait on the second device to be disconnected. It worked as expected 👍

@CDRussell CDRussell requested a review from Copilot March 17, 2025 09:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@CDRussell CDRussell requested a review from Copilot March 17, 2025 09:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@CDRussell CDRussell force-pushed the feature/craig/automatically_refreshing_sync_activity branch from ceb1f46 to 7348ea6 Compare March 17, 2025 09:57
@CDRussell CDRussell merged commit 9ed7886 into develop Mar 17, 2025
6 checks passed
@CDRussell CDRussell deleted the feature/craig/automatically_refreshing_sync_activity branch March 17, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants