Skip to content

fix incorrect end node index access in large polygon-distance check #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

fix incorrect end node index access in large polygon-distance check #661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c7ea31
fix incorrect end node index access
Maxxen Aug 13, 2025
92c7ce0
dont include start of last node
Maxxen Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/sgl/sgl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2409,7 +2409,13 @@ point_in_polygon_result prepared_geometry::contains(const vertex_xy &vert) const
return crossings % 2 == 0 ? point_in_polygon_result::EXTERIOR : point_in_polygon_result::INTERIOR;
}

if(stack[depth] != index.level_array[depth].entry_count - 1) {
// The end of this node is either the end of the current node, or the end of the level
const auto node_end = ((stack[depth - 1] + 1) * NODE_SIZE) - 1;
const auto levl_end = index.level_array[depth].entry_count - 1;

const auto end = math::min(node_end, levl_end);

if(stack[depth] != end) {
// Go sideways!
stack[depth]++;
break;
Expand Down
Loading