Skip to content

CLI occasionally checks for newer version #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mushketyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CLI occasionally checks for newer version #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions lib/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,19 @@ let cli = require("commander"),
path = require("path"),
chokidar = require("chokidar"),
traverse = require("sol-digger"),
axios = require("axios"),
semver = require("semver"),
solium = require("./solium"),
sum = require("lodash/sum"),
version = require("../package.json").version;
require("colors");

let CWD = process.cwd(),
SOLIUMRC_FILENAME = ".soliumrc.json",
SOLIUMRC_FILENAME_ABSOLUTE = path.join(CWD, SOLIUMRC_FILENAME),
SOLIUMIGNORE_FILENAME = ".soliumignore",
SOLIUMIGNORE_FILENAME_ABSOLUTE = path.join(CWD, SOLIUMIGNORE_FILENAME),
VERSION_CHECK_CHANCE = 0.05,
DEFAULT_SOLIUMIGNORE_PATH = __dirname + "/cli-utils/.default-solium-ignore",
DEFAULT_SOLIUMRC_PATH = __dirname + "/cli-utils/.default-soliumrc.json";

Expand Down Expand Up @@ -236,7 +240,35 @@ function getErrorReporter(name) {
* @param {Array} programArgs Commandline arguments
*/
function execute(programArgs) {
if (Math.random() < VERSION_CHECK_CHANCE) {
checkVersionAndRunSolium(programArgs);
} else {
runSolium(programArgs);
}
}

function checkVersionAndRunSolium(programArgs) {
let soliumNpmUrl = "https://registry.npmjs.org/solium?version=latest";

axios.get(soliumNpmUrl)
.then(function(response) {
const latestVersion = response.data.version;
if (semver.gt(version, latestVersion)) {
process.stdout.write(`You are running a dev version ${version}, laterst version is ${latestVersion}`.yellow);
} else if (semver.lt(version, latestVersion)) {
process.stdout.write(`You are runninng an outdated version ${version}, latest version is ${latestVersion}`.yellow);
} else {
process.stdout.write(`You are runninng the latest version: ${version}`.green);
}
runSolium(programArgs);
})
.catch(function(error) {
process.stdout.write(`Failed to get solium version: ${error}`);
runSolium(programArgs);
});
}

function runSolium(programArgs) {
let userConfig, ignore, errorReporter;

createCliOptions(cli);
Expand Down
20 changes: 18 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@
"license": "MIT",
"dependencies": {
"ajv": "^5.2.2",
"axios": "^0.18.0",
"chokidar": "^1.6.0",
"colors": "^1.1.2",
"commander": "^2.9.0",
"js-string-escape": "^1.0.1",
"lodash": "^4.14.2",
"semver": "^5.5.0",
"sol-digger": "0.0.2",
"sol-explore": "1.6.1",
"solium-plugin-security": "0.1.1",
Expand Down