Add NovelsOnline.org to NovelsOnline Parser and Extract Author
#2298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be the same and it was not currenlty handled
pjkaufman
changed the title
NovelsOnline.org to NovelsOnline ParserNovelsOnline.org to NovelsOnline Parser and Extract Author
Owner
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if the site is a clone or just a rebrand of the other one, but
novelsonline.orgseems to have the exact same structure as what was expected fornovelsonline.net. So I just added it as an option for download. It seems to have identified the data as expected.I also went ahead and included the extraction of the author. I was not sure if we could guarantee that the author would always be at a specific child index in the html, so I instead opted to iterate over the possible elements and find it that way. It should work relatively quickly, but if we want to hard code the child element instead, that could be done too.