Skip to content

SUMO Groundtruth Reader#827

Closed
hpritchett-dstl wants to merge 12 commits intomainfrom
sumo_gt_reader
Closed

SUMO Groundtruth Reader#827
hpritchett-dstl wants to merge 12 commits intomainfrom
sumo_gt_reader

Conversation

@hpritchett-dstl
Copy link
Copy Markdown
Contributor

@hpritchett-dstl hpritchett-dstl commented Jul 11, 2023

This pull request introduces a new groundtruth reader, namely the SUMOGroundTruthReader which utilizes the urban mobility simulation software, SUMO.
See: https://github.com/eclipse/sumo

@hpritchett-dstl hpritchett-dstl requested a review from a team as a code owner July 11, 2023 14:08
@hpritchett-dstl hpritchett-dstl requested review from orosoman-dstl and sdhiscocks and removed request for a team July 11, 2023 14:08
@hpritchett-dstl hpritchett-dstl changed the title Sumo gt reader SUMO Groundtruth Reader Jul 11, 2023
@dalybrown
Copy link
Copy Markdown

This is actually pretty cool and topical. We are using SUMO + MOSAIC and Stone Soup for simulation in our company! I wrote a MOSAIC plugin (a new ambassador in their terminology) that converts MOSAIC objects to DIS (Distributed Interactive Simulation) entities so that SUMO + MOSAIC can be used for ground truth simulation with DIS. I also wrote a Stone Soup DIS reader to read in that ground truth from a DIS entity state PDU so that we can use the data in Stone Soup.

The pipeline goes: SUMO --> MOSAIC --> DIS Ambassador --> Stone Soup DIS Reader --> Stone Soup.

I was planning on contributing the reader back to here and the ambassador back to MOSAIC eventually when I've used it a bit more (the DIS part is not nearly feature complete). If people are interested in a very early version of the reader (it will need additional work) I can contribute it sooner.

@hpritchett-dstl
Copy link
Copy Markdown
Contributor Author

It's good to hear how you're using Stone Soup! Hopefully this SUMO reader can be a good starting point for those looking at using both pieces of software.

I was planning on contributing the reader back to here and the ambassador back to MOSAIC eventually when I've used it a bit more (the DIS part is not nearly feature complete). If people are interested in a very early version of the reader (it will need additional work) I can contribute it sooner.

I think your DIS Reader would make a great addition to the repository, and would encourage you to contribute it when it's in a form you're happy with.

Comment thread stonesoup/reader/sumo.py Outdated
@dalybrown
Copy link
Copy Markdown

It's good to hear how you're using Stone Soup! Hopefully this SUMO reader can be a good starting point for those looking at using both pieces of software.

I was planning on contributing the reader back to here and the ambassador back to MOSAIC eventually when I've used it a bit more (the DIS part is not nearly feature complete). If people are interested in a very early version of the reader (it will need additional work) I can contribute it sooner.

I think your DIS Reader would make a great addition to the repository, and would encourage you to contribute it when it's in a form you're happy with.

I created an issue to remind me to do this: #849.

Comment thread stonesoup/reader/sumo.py Outdated
sys.path.append(tools)
import traci
else:
sys.exit("Declare environment variable 'SUMO_HOME'")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just raise an error, rather than sys.exit()

@mharris-dstl mharris-dstl self-requested a review January 16, 2024 16:00
@sdhiscocks
Copy link
Copy Markdown
Member

Included in #1128

@sdhiscocks sdhiscocks closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants