-
Notifications
You must be signed in to change notification settings - Fork 5
Add tool for partial generation of AWS Cloud spec document #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can this pull request also be reviewed by @schwichti or the System-Team, as I am not an expert in this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider to move this script into a separate repo? The code kind of bloats this repo (terraform init
will also unnecessarily download the script).
I discussed this again with Thomas: We agreed to keep the script in this repo. |
For the beginning, I am ok with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment and two suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces typescript script and configuration used to partially generate AWSCloudSpec.md.
Tool is used with node.js. Environment installation instructions can be found in respective directory in README.md.
This tool has been created by @schwichti and is extended by me. It does not fulfill all code guidelines nor full expected functionality, but it greatly helps in updating AWSCloudSpec.md document.