Skip to content

Conversation

vradicevicds
Copy link
Contributor

@vradicevicds vradicevicds commented May 8, 2025

This PR introduces typescript script and configuration used to partially generate AWSCloudSpec.md.
Tool is used with node.js. Environment installation instructions can be found in respective directory in README.md.

This tool has been created by @schwichti and is extended by me. It does not fulfill all code guidelines nor full expected functionality, but it greatly helps in updating AWSCloudSpec.md document.

@sgrdn
Copy link
Contributor

sgrdn commented May 12, 2025

Can this pull request also be reviewed by @schwichti or the System-Team, as I am not an expert in this.

Copy link
Contributor

@schwichti schwichti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider to move this script into a separate repo? The code kind of bloats this repo (terraform init will also unnecessarily download the script).

@sgrdn
Copy link
Contributor

sgrdn commented May 19, 2025

Did you consider to move this script into a separate repo? The code kind of bloats this repo (terraform init will also unnecessarily download the script).

I discussed this again with Thomas: We agreed to keep the script in this repo.

@schwichti
Copy link
Contributor

For the beginning, I am ok with this PR.
Disclaimer: I did not review/run the scripts.

sohamk10
sohamk10 previously approved these changes Aug 7, 2025
Copy link
Contributor

@sohamk10 sohamk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RenjithPNair RenjithPNair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment and two suggestions.

Copy link
Contributor

@RenjithPNair RenjithPNair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sohamk10 sohamk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vradicevicds vradicevicds merged commit 3d8ce8e into main Aug 12, 2025
1 check passed
@vradicevicds vradicevicds deleted the cot/aws_cloud_spec_gen branch August 12, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants