Remove stale ANTLR 3.2 references and readme.txt#1308
Draft
joaodinissf wants to merge 3 commits into
Draft
Conversation
joaodinissf
force-pushed
the
chore/remove-stale-readme
branch
from
98aa121 to
9a5b925
Compare
- ddk-parent/readme.txt: stale instruction from initial commit (2016) to download antlr-generator-3.2.0.jar manually - ddk-target/ddk-antlr.target: orphaned target file not referenced by any pom.xml, with stale repo URLs (Orbit 2022, SWTBot 4.0.0). Its only unique dep (de.itemis.xtext.antlr) is unused by any code - GenerateTestLanguage.mwe2.launch: remove broken classpath entry for non-existent antlr-generator jar Note: .gitignore entries in workflow/ and sample.helloworld/ are kept — Xtext's AntlrToolFacade auto-downloads antlr-generator-3.2.0-patch.jar when running MWE2 grammar generation, and the gitignores correctly prevent accidental commits of this auto-downloaded artifact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fixes access restriction errors for IDocument, IDocumentExtension3, and Region in the quickfix package. The bundle uses these types from org.eclipse.text but didn't declare the dependency in MANIFEST.MF. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Captured during core-ui-split PoC investigation. Covers: - NPE in EcoreGeneratorFragment2 (dsldevkit#1309) - Missing "run all generators" launch config - Dead itemis ANTLR p2 repository - MWE2 xtend-gen conflicts - Structural issues (no root pom, ddk-target packaging) - Broken -am for Tycho modules - Empty xtextspy modules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/remove-stale-readme
branch
from
9a5b925 to
dab42af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ddk-parent/readme.txt— leftover from initial commit (2016), instructs to manually download a jar that was never committedddk-target/ddk-antlr.target— orphaned target file not referenced by any pom.xml, with stale repo URLs (Orbit 2022, SWTBot 4.0.0). Its only unique dep (de.itemis.xtext.antlr) is not used by any code. ANTLR runtime comes transitively via Xtext inddk.targetGenerateTestLanguage.mwe2.launchreferencing non-existent jarNote:
.gitignoreentries inworkflow/andsample.helloworld/are intentionally kept — Xtext'sAntlrToolFacadeauto-downloadsantlr-generator-3.2.0-patch.jarwhen running MWE2 grammar generation workflows, and the gitignores prevent accidental commits.Test plan
mvn verifystill passes fromddk-parent/(no build file referenced these)ddk.targetGenerateTestLanguage.mwe2from Eclipse to confirm grammar generation still works🤖 Generated with Claude Code