fix: Fix junit5 test suites not running#1213
Merged
Merged
Conversation
rubenporras
requested changes
Nov 5, 2025
Member
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
can we undo as well all the whitespace changes to the .gitignore files? I think the easiest is just to take them out of the PR.
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Member
There was a problem hiding this comment.
can you undo this change? I think the project was deleted by me
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
they are not executed because the master suite AllTest is still in junit4 suite. the fix includes: - changing the AllTest.java to use the junit5 suite api - use SelectClasses instead of SelectPackages, to prevent the platform engine from discovering unrelated packages which causes errors in the build - suppress the warning PMD.JUnit5TestShouldBePackagePrivate because our tests are executed in test suites and must be public - fixed discovered failing tests
rubenporras
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they are not executed because the master suite AllTest is still in junit4 suite. the fix includes: