Open
Conversation
I updated the code from Python 2 to Python 3 using the application 2to3 I ran this script to convert the code from pygtk to python-gobject: https://gitlab.gnome.org/GNOME/pygobject/blob/master/tools/pygi-convert.sh Converted the glade file to the current format Removed some obsolete properties from the glade file Changed the way the glade file was loaded Changed the check of the klick version - the check doesn't do anything useful now - it should be either fixed or removed Changed the call of signal_autoconnect to connect_signals
…get_object() using this command: for file in *.py; do sed -i 's;widgets\[\([^]]*\)\];wtree.get_object\(\1\);g' $file; done also cleaned up the setup method in gtklick.py
also removed some comments
…I'm not sure if they're still needed Also added a few imports
…t works properly now
…was working in the past - I have possibly broken packaging with this but it works in development environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Dominic,
I've updated the code for gtklick to work with Python 3, GTK 3 and the latest version of Glade.
There was some code in profiles_pane.py (self.renderer.connect('edited', misc.weakref_method(self.on_cell_edited))) that I didn't understand (I don't know what a "weakref" is). I altered the code enough that it runs - I don't think the thread terminates properly when you close the program though.
It runs OK on my PC with the exception that the last time I ran it I don't think it was saving settings properly.
I did this work over a year ago and lost motivation to work on it further so I'm sending this pull request in the hope of getting some feedback from you. I'm not sure what your intentions are regarding the gtklick project and whether you would be interested in helping me fix these bugs or not - if you would (or could just provide some advice on how to proceed) that would be great. I can figure out how to fix that weakref problem but a bit of help would make it a lot easier.
If it's not obvious, I don't have a lot of experience with contributing to open source projects so I apologise in advance if I haven't followed normal procedures.