Skip to content

fix(tests): accept quoted url values in url_present_in_outputs_yaml #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobPEvans-personal merged 1 commit into from
May 24, 2026
Merged

fix(tests): accept quoted url values in url_present_in_outputs_yaml #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@ def send_trace_with_retry(
def url_present_in_outputs_yaml(url: str, yaml_text: str) -> bool:
"""Return True if url appears as a 'url:' value in the YAML text.

Matches lines of the form: url: <value> (with optional surrounding whitespace).
Matches lines of the form: url: <value> with optional surrounding
whitespace and an optional matching pair of single or double quotes
around the value. The Cribl Stream configmap template wraps the URL
in double quotes
(k8s/monitoring/cribl-stream-standalone/configmap-cribl-config.yaml),
so the deployed outputs.yml renders as `url: "https://..."`; strict
unquoted matching gives a false negative.
"""
return bool(re.search(rf"^\s*url:\s*{re.escape(url)}\s*$", yaml_text, re.MULTILINE))
return bool(re.search(rf"""^\s*url:\s*(['"]?){re.escape(url)}\1\s*$""", yaml_text, re.MULTILINE))
Loading