Add possibility to specify recipient model #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubickcz
force-pushed
the
add_possibility_to_change_recipient_model
branch
7 times, most recently
from
7184b40 to
0b8b2df
Compare
rubickcz
commented
Oct 12, 2020
setup.py
Outdated
| 'beautifulsoup4 ~=4.8.0', | ||
| 'celery >= 4.2.0', | ||
| 'django >= 2.2', | ||
| 'django ~= 2.2', |
Member
Author
There was a problem hiding this comment.
The former statement installs Django 3, this library is not yet ported to Django 3.
rubickcz
force-pushed
the
add_possibility_to_change_recipient_model
branch
3 times, most recently
from
87dbe98 to
40dcb09
Compare
rubickcz
commented
Oct 12, 2020
requirements_docs.txt
Outdated
| celery==4.2.0 | ||
| django-chamber==0.5.0 | ||
| django==2.2 | ||
| lxml==4.5.0 |
Member
Author
There was a problem hiding this comment.
Added missing requirements from setup.py, that prevented docs to be rendered.
rubickcz
force-pushed
the
add_possibility_to_change_recipient_model
branch
2 times, most recently
from
7ad7431 to
a723801
Compare
rubickcz
commented
Oct 12, 2020
| 'celery==4.*', | ||
| 'django==2.*', | ||
| 'django-chamber==0.*', | ||
| 'lxml==4.*', |
Member
Author
There was a problem hiding this comment.
A little bit restricted compatibility, but I think it's still OK.
rubickcz
force-pushed
the
add_possibility_to_change_recipient_model
branch
from
a723801 to
57d8a2c
Compare
matllubos
approved these changes
Oct 18, 2020
Formulka
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pynotify uses
AUTH_USER_MODELsetting for recipient model, which is also used by Django authentication mechanism. But some projects might require to use different model for notifications, thereforePYNOTIFY_RECIPIENT_MODELis introduced in this PR.