Present the cooked potatoe directly to the consumer #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigfoot547
suggested changes
Dec 22, 2020
| org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning | ||
| org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=ignore | ||
| org.eclipse.jdt.core.compiler.release=disabled | ||
| org.eclipse.jdt.core.compiler.source=1.8 |
There was a problem hiding this comment.
Please add .settings to the .gitignore.
| * | ||
| * @return void | ||
| */ | ||
| public void servePotato() { |
There was a problem hiding this comment.
The code style of this method is discordant with the rest of the project.
| } catch (NotDeliciousException e) { | ||
| potato.servePotato(); | ||
| } | ||
| catch (NotDeliciousException e) { |
There was a problem hiding this comment.
Please fix the style of this catch as well.
| potato.servePotato(); | ||
| } | ||
| catch (NotDeliciousException e) { | ||
| System.err.println("Fatal error! How could Potato not be delicious?\nReason: " + e.getReason()); |
There was a problem hiding this comment.
Suggested change
| System.err.println("Fatal error! How could Potato not be delicious?\nReason: " + e.getReason()); | |
| System.err.println("Fatal error! How could Potato not be delicious?"); | |
| System.err.println("Reason: " + e.getReason()); |
| System.out.println("Done."); | ||
| } | ||
| catch (IOException ex) { | ||
| System.out.print("whoops"); |
There was a problem hiding this comment.
Some more explanatory messages would do well here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.