Add self-relation support when relationsDepthLimit is set#39
Open
dmythro wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for self-relations (tables referencing themselves) when a relationsDepthLimit is configured. Previously, self-relations were blocked by the usedTables check regardless of depth limit settings.
- Modified the condition in
generateSelectFieldsto allow self-relations whenrelationsDepthLimitis set - Added
parentIdcolumn to Posts table schema for self-referencing functionality - Added comprehensive tests covering both default behavior (blocking self-relations) and new behavior (allowing self-relations with depth limits)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/util/builders/common.ts | Updated logic to conditionally apply usedTables check based on relationsDepthLimit setting |
| tests/schema/pg.ts | Added parentId column and parent/replies relations for self-referencing Posts |
| tests/pg.test.ts | Added extensive test coverage for self-relation behavior with and without depth limits |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplest way I found to allow self-relations securely (avoiding infinite depth etc), without breaking anything else or introducing extra configuration.
Issue: #38