Skip to content

Fix:#640 Optimized formatHex method for efficiency and memory usage #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Salman-Sayyed wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix:#640 Optimized formatHex method for efficiency and memory usage #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/com/drew/metadata/bmp/BmpHeaderDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ public static String formatHex(@Nullable Long value, int digits) {

@NotNull
public static String formatHex(long value, int digits) {
return String.format("0x%0"+ digits + "X", value);
StringBuilder sb = new StringBuilder();
sb.append("0x");
long maskedValue = value & ((1L << (digits * 4)) - 1);
int leadingZeros = Long.numberOfLeadingZeros(maskedValue) >> 2;
sb.append(Long.toHexString(maskedValue | (1L << (digits * 4))).substring(leadingZeros));
return sb.toString();
}

@Nullable
Expand Down