Skip to content

FEATURE Several attempts to run Crowdin CLI #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dshiryaev-plesk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FEATURE Several attempts to run Crowdin CLI #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions lib/Serge/Sync/Plugin/TranslationService/crowdin.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,16 @@ sub init {

$self->SUPER::init(@_);

$self->{optimizations} = 1;
$self->{optimizations} = 1;

$self->merge_schema({
config_file => 'STRING',
upload_translations => 'BOOLEAN',
import_duplicates => 'BOOLEAN',
import_eq_suggestions => 'BOOLEAN',
auto_approve_imported => 'BOOLEAN',
backoff_max_attempts => 'STRING',
backoff_exp_base => 'STRING',
});
}

Expand All @@ -40,6 +42,8 @@ sub validate_data {
$self->{data}->{import_duplicates} = subst_macros($self->{data}->{import_duplicates});
$self->{data}->{import_eq_suggestions} = subst_macros($self->{data}->{import_eq_suggestions});
$self->{data}->{auto_approve_imported} = subst_macros($self->{data}->{auto_approve_imported});
$self->{data}->{backoff_max_attempts} = subst_macros($self->{data}->{backoff_max_attempts});
$self->{data}->{backoff_exp_base} = subst_macros($self->{data}->{backoff_exp_base});

die "'config_file' not defined" unless defined $self->{data}->{config_file};
die "'config_file', which is set to '$self->{data}->{config_file}', does not point to a valid file.\n" unless -f $self->{data}->{config_file};
Expand All @@ -48,6 +52,8 @@ sub validate_data {
$self->{data}->{import_duplicates} = 0 unless defined $self->{data}->{import_duplicates};
$self->{data}->{import_eq_suggestions} = 0 unless defined $self->{data}->{import_eq_suggestions};
$self->{data}->{auto_approve_imported} = 0 unless defined $self->{data}->{auto_approve_imported};
$self->{data}->{backoff_max_attempts} = 3 unless defined $self->{data}->{backoff_max_attempts};
$self->{data}->{backoff_exp_base} = 8 unless defined $self->{data}->{backoff_exp_base};
}

sub run_crowdin_cli {
Expand All @@ -65,8 +71,30 @@ sub run_crowdin_cli {
$command .= ' --config '.$self->{data}->{config_file};

$command = 'crowdin '.$command;
print "Running '$command'...\n";
return $self->run_cmd($command, $capture);

my $cli_return;
for (
my $attempt = 1;
$attempt <= $self->{data}->{backoff_max_attempts} &&
!eval {
print "Running '$command'...\n";
$cli_return = $self->run_cmd($command, $capture);
return 1;
};
$attempt++
) {
my $message = "Failed to call Crowdin CLI on attempt $attempt: $@\n";
if ($attempt >= $self->{data}->{backoff_max_attempts}) {
die $message;
} else {
print "Error. $message";
my $sleep = $self->{data}->{backoff_exp_base} ** $attempt;
print "Sleep for $sleep seconds\n";
sleep $sleep;
}
}

return $cli_return;
}

sub pull_ts {
Expand Down