Evidence table

[amcdonaldSC]

Summary

Modified the process_report_item function to fetch the IP, FQDN, RDNS, and Netbios values from the xml_host object and add them to a clone of the xml_report_item object so they are accessible as evidence parameters.

Added the parameter names to the fields list, and report_item.rb so they are allow-listed, added the parameters to the evidence.fields, and created an updated sample template with the new parameters.

Other Information

Some changes to report_item.rb may be redundant/unnecessary. Testing was done in the CE edition with a limited data-set.

Copyright assignment

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

[amcdonaldSC]

For my particular use case, I also added this, because a partial FQDN is more useful than none:
fqdn = netbios.downcase if fqdn.nil? || fqdn.empty?

[randomactsofsecurity]

Any update on getting this feature merged into master?

[randomactsofsecurity]

@aapomm Any update on getting this feature merged into master?

[aapomm]

I tested this PR and it works as expected. Unfortunately, this isn't something we can merge since the approach is not consistent with the rest of the plugin. Specifically, the importer class shouldn't be aware of the nessus item, its fields and the values. Ideally, the more consistent approach would be to pass the xml_host to the evidence template and make evidence closer to ReportHost (where the HostProperties are) than ReportItem.

Evidence content should be generated with something like this:

evidence_content = template_service.process_template(template: 'evidence', data: xml_host)

This way, Nessus::Host will be available from the evidence level.

Note that this is now applied in #41. Closing this now.