add multi-file uploads with auto-detection of the source tool#1570
Open
MattBudz wants to merge 3 commits into
Open
add multi-file uploads with auto-detection of the source tool#1570MattBudz wants to merge 3 commits into
MattBudz wants to merge 3 commits into
Conversation
Replaces the single-file form with a drop zone that accepts N files at once. Each file gets its own row; client-side detector modules identify the tool automatically so users never have to pick it from a list. Parallel POSTs fan out to N UploadJobs. Per-row progress bars and console modals replace the old page-global console. CE learns nothing about specific tool formats: all detection logic travels through the engine .upload_detectors class method + importmap contribution pattern introduced in the Qualys gem.
Rewrites the upload feature spec to use the new drop-zone UI and adds scenarios for row management and the Upload button's ready state. Adds a request spec verifying the JSON response shape for POST /upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for the multi-file smart upload feature.
Summary
Replaces the single-file upload form with a multi-file staging UI that auto-detects the source tool for each file before uploading.
upload_detector_registry) is a thin JS module that importer gems contribute to via importmap side-effectsRequires dradis/dradis-qualys#73 and dradis/dradis-nessus#79 for Qualys and Nessus auto-detection respectively. Any importer gem can add its own detector by implementing
upload_detectorson the engine and contributing a JS detector module.Check List