[SD-1639] Views: table click sorting issue#746
Open
vincent-gao wants to merge 1 commit intodevelopfrom
Open
Conversation
Fxies an issue: views: Table click sorting does not respect a defined sort plugin.
vincent-gao
force-pushed
the
feature/SD-1639-table-click-sorting-does-not-use-a-defined-sort-plugin
branch
from
7d5b87a to
5f91b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fxies an issue: views: Table click sorting does not respect a defined sort plugin.
Jira
https://digital-vic.atlassian.net/browse/SD-1639
Change
Drupal core's EntityField::clickSort() implements its own simple sorting logic (ORDER BY raw field value) which completely ignores any custom sort plugin defined for the same field.
the change fixes the issue by checking whether a matching sort handler exists in the view. If found, it delegates click sorting to that handler's query() method, ensuring table header click sorting respects the custom sort logic.
see https://www.drupal.org/project/drupal/issues/3174392 to get more details.