Repository navigation
Stop paging when a Fargate task is already deprovisioning - #15
Merged
Merged
Conversation
After StopTask is accepted, Fargate can sit in DEPROVISIONING for minutes while the ENI detaches. Exhausting the deprovision budget is not a StopTask failure — drop the ARN with a warning instead of Sentry error + failedStops retry. not-accepted and API errors still retry and report once. Fixes CONDUIT-N Fixes CONDUIT-T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CONDUIT-N
Fixes CONDUIT-T
After
StopTaskis accepted, Fargate often stays inDEPROVISIONINGfor minutes while the ENI detaches. The stop path treated "not STOPPED yet" as a failure, retriedStopTask, and reported it to Sentry (did not reach STOPPED, thenGiving up stopping task … after 3 attempt(s)).The deprovision budget is unchanged. When it elapses and the stop was already accepted, Conduit now drops the task ARN, logs one warning, and does not send a Sentry error or schedule another
StopTask. A task that staysRUNNING(stop never accepted) and realStopTaskAPI errors still retry and report once. Shutdown no longer waits on an ARN that is already stopping.CONDUIT-Y was checked and left as-is. An unadopted remote worker that never reconnects after a server restart still fails when the reconnect window elapses; that matches the current recovery design.
npx vitest run src/server/workers/fargateWorker.test.ts— 50 passed.