Skip to content

Merge dotnet/templating catch-up: 4 commits missed in Phase 1 #53734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelSimons merged 4 commits into from
Apr 7, 2026
Merged

Merge dotnet/templating catch-up: 4 commits missed in Phase 1 #53734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30ab7eb
Fix MockTemplateInfo for System.Text.Json serialization
lewing Mar 27, 2026
794186a
Specify target framework
NikolaMilosavljevic Mar 30, 2026
fc74688
Use NetCurrent
NikolaMilosavljevic Mar 30, 2026
9e503cf
Run once a day
NikolaMilosavljevic Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions eng/pipelines/search-cache-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
trigger: none
# Trigger periodically instead.
schedules:
- cron: 0 * * * *
displayName: Run every hour
- cron: 0 0 * * *
displayName: Run once a day
branches:
include:
- main
Expand Down Expand Up @@ -137,10 +137,14 @@ extends:
-SkipNonVersionedFiles
displayName: Install latest daily .NET version
- bash: >
$(Build.SourcesDirectory)/.dotnet/dotnet run --no-build
--project $(Build.SourcesDirectory)/tools/Microsoft.TemplateSearch.TemplateDiscovery/Microsoft.TemplateSearch.TemplateDiscovery.csproj
-- --basePath $(System.DefaultWorkingDirectory)/NugetDownloadDirectory --allowPreviewPacks -v --test --diff $(EnableDiffMode)
- bash: |
projectPath=$(Build.SourcesDirectory)/tools/Microsoft.TemplateSearch.TemplateDiscovery/Microsoft.TemplateSearch.TemplateDiscovery.csproj
Comment thread
MichaelSimons marked this conversation as resolved.
netCurrent=$($(Build.SourcesDirectory)/.dotnet/dotnet msbuild $projectPath -getProperty:NetCurrent)
echo "Resolved NetCurrent: $netCurrent"
$(Build.SourcesDirectory)/.dotnet/dotnet run --no-build \
Comment thread
MichaelSimons marked this conversation as resolved.
--framework $netCurrent \
--project $projectPath \
-- --basePath $(System.DefaultWorkingDirectory)/NugetDownloadDirectory --allowPreviewPacks -v --test --diff $(EnableDiffMode)
displayName: Run Cache Updater
- task: CopyFiles@2
Expand Down
4 changes: 2 additions & 2 deletions test/TemplateEngine/Microsoft.TemplateEngine.Mocks/MockTemplateInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ public string ShortName
public bool PreferDefaultName => _preferDefaultName;

[Obsolete("Use ParameterDefinitionSet instead.")]
IReadOnlyDictionary<string, ICacheTag> ITemplateInfo.Tags => throw new NotImplementedException();
IReadOnlyDictionary<string, ICacheTag> ITemplateInfo.Tags => null!;

[Obsolete("Use ParameterDefinitionSet instead.")]
IReadOnlyDictionary<string, ICacheParameter> ITemplateInfo.CacheParameters => throw new NotImplementedException();
IReadOnlyDictionary<string, ICacheParameter> ITemplateInfo.CacheParameters => null!;
Comment thread
MichaelSimons marked this conversation as resolved.

public IParameterDefinitionSet ParameterDefinitions
{
Expand Down
Loading