Improve SDK resolver error messages when global.json rollforward selects an incompatible SDK#53632
Draft
Improve SDK resolver error messages when global.json rollforward selects an incompatible SDK#53632
Conversation
…atible SDK Agent-Logs-Url: https://github.com/dotnet/sdk/sessions/653e8d69-6576-467e-a866-65f14243ffc2 Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
marcpopMSFT
March 30, 2026 20:43
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
global.jsonspecifies arollForwardpolicy that causes a newer SDK to be selected, and that SDK fails the MSBuild minimum version check or the VS-defined minimum SDK version check, the error today mentions only the resolved SDK version—not that it was chosen via rollforward. Users see a confusing mismatch between what they put inglobal.jsonand the version being complained about.Changes
Strings.resx): Two rollforward-specific variants of the existing version-mismatch messages that surface the global.json path, the originally-requested version, and actionable guidance to adjustrollForward.MSBuildSdkResolver.cs): AddedIsGlobalJsonRollforwardhelper — fires whenGlobalJsonPathis set and the resolved SDK version differs fromRequestedVersion. Both version-check failure paths branch to the new messages when rollforward is detected.GivenAnMSBuildSdkResolver.cs): ExtendedCreateGlobalJsonwith an optionalrollForwardparameter; added two tests covering each new error path.Before:
After: