Consolidate default verbosity of msbuild-based commands #50243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the default verbosity setting for MSBuild-based commands to ensure consistent behavior across the dotnet CLI. The change addresses issue #50227 by centralizing the default verbosity configuration.
- Introduces a centralized
DefaultVerbosityconstant set toVerbosityOptions.m - Updates
VirtualProjectBuildingCommandto use the centralized default instead of hardcodedquietverbosity - Adds comprehensive tests to verify verbosity behavior for run, build, and compilation diagnostic scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs | Defines centralized DefaultVerbosity constant and updates class to be sealed |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Updates to use centralized default verbosity instead of hardcoded quiet |
| src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildArgs.cs | Minor cleanup removing unused using statement and empty XML doc return tag |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds tests for verbosity behavior in run, build, and compilation diagnostic scenarios |
MiYanni
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50227.