Skip to content

[wasm] Use instantiating stubs for default interface dispatch #133924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidwrighton wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

[wasm] Use instantiating stubs for default interface dispatch #133924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2350,6 +2350,11 @@ private void ceeInfoGetCallInfo(
(_compilation.NodeFactory.Target.IsWasm &&
targetMethod.OwningType.IsInterface))
{
if (!targetMethod.HasInstantiation)
{
// If it is also a default interface method call, it should go through instantiating stub.
useInstantiatingStub = useInstantiatingStub || (targetMethod.OwningType.IsInterface && !originalMethod.IsAbstract);

@BrzVlad BrzVlad Sep 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason why we need instantiating stubs on wasm ? They are always in danger of being interpreted and I'm wondering why would they even be needed. Isn't any method able to obtain its method context directly from the PEP.

}
pResult->kind = CORINFO_CALL_KIND.CORINFO_VIRTUALCALL_LDVIRTFTN; // stub dispatch can't handle generic method calls yet
pResult->nullInstanceCheck = true;
}
Expand Down
1 change: 0 additions & 1 deletion ...sts/Loader/classloader/StaticVirtualMethods/InterfaceVariance/ComplexHierarchyPositive.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/88689", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/133466", typeof(TestLibrary.PlatformDetection), nameof(TestLibrary.PlatformDetection.IsWasmReadyToRun))]
public static void TestEntryPoint()
{
Console.WriteLine("Test cases");
Expand Down
Loading