JIT: Preserve receiver side effects in constrained GetType calls - #133806
Open
EgorBo wants to merge 1 commit into
Open
JIT: Preserve receiver side effects in constrained GetType calls#133806EgorBo wants to merge 1 commit into
EgorBo wants to merge 1 commit into
Conversation
Preserve receiver evaluation and the null check that boxing would perform when expanding constrained GetType calls. Add a source-only regression covering bounds checks, null arrays, and null byrefs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1ad7889-9252-4fe8-a399-88e91f2652be
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Fixes a JIT bug where constrained GetType() optimization discarded receiver side effects and required checks.
Changes:
- Preserves receiver evaluation, bounds checks, and null checks.
- Adds regression coverage for
intandGuid.
File summaries
| File | Description |
|---|---|
src/tests/JIT/Regression_ro_2/Runtime_133715.cs |
Adds regression tests for valid, bounds-error, and null cases. |
src/coreclr/jit/importercalls.cpp |
Preserves receiver side effects during constrained GetType() expansion. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133715.
The constrained
Object.GetType()expansion discarded the receiver tree when replacing boxing with direct type construction, losing bounds checks and other side effects. Preserve receiver evaluation and the null check that boxing would perform, while retaining the boxing optimization.