Remove redundant fAcquireLock from binder SetupBindingPaths - #132290
Merged
Conversation
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CoreCLR binder ApplicationContext::SetupBindingPaths API by removing the now-redundant fAcquireLock parameter and unconditionally acquiring the application context critical section while initializing binding path state.
Changes:
- Removed the
fAcquireLockparameter fromApplicationContext::SetupBindingPaths(declaration + definition). - Updated
SetupBindingPathsto always take the context lock viaCRITSEC_Holder contextLock(GetCriticalSectionCookie()). - Updated the sole call site in
DefaultAssemblyBinder::SetupBindingPathsto match the new signature.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/binder/inc/applicationcontext.hpp | Updates ApplicationContext::SetupBindingPaths declaration to remove fAcquireLock. |
| src/coreclr/binder/applicationcontext.cpp | Removes conditional locking and always acquires the context critical section in SetupBindingPaths. |
| src/coreclr/binder/defaultassemblybinder.cpp | Updates the only call site to the new SetupBindingPaths signature. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
Copilot
AI
changed the title
Remove unused fAcquireLock parameter from SetupBindingPaths
Remove redundant Aug 13, 2026
fAcquireLock from binder SetupBindingPaths
Copilot created this pull request from a session on behalf of
elinor-fung
August 13, 2026 20:11
View session
elinor-fung
marked this pull request as ready for review
August 13, 2026 20:31
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @elinor-fung |
jkotas
reviewed
Aug 13, 2026
jkotas
reviewed
Aug 13, 2026
elinor-fung
reviewed
Aug 13, 2026
elinor-fung
reviewed
Aug 13, 2026
jkotas
approved these changes
Aug 13, 2026
This was referenced Aug 14, 2026
Member
|
/ba-g build analysis misclassifying known test failures - dotnet/arcade#17340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a dead boolean parameter from CoreCLR binder path setup.
ApplicationContext::SetupBindingPathshad a lock-control argument that was always passed asTRUE.