Fold installer build and test into CoreCLR jobs - #132284
Conversation
Add the installer subsets and Helix submissions to the CoreCLR_AllSubsets jobs while preserving installer queues and path-based conditions. Remove the standalone jobs and obsolete artifact handoff. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
This PR refactors the runtime.yml CI pipeline to eliminate standalone “Installer Build and Test” jobs by folding installer build + Helix submission into the existing CoreCLR/Libraries producer jobs, reducing cross-job artifact handoff and duplicated work.
Changes:
- Renames the consolidated CoreCLR/Libraries producer jobs to
CoreCLR_AllSubsetsand addshost+packsto the build subsets. - Moves installer Helix submission into
postBuildStepswith the same path-based conditions (including the macOS arm64-on-coreclr-change trigger). - Converts
eng/pipelines/installer/helix-queues-setup.ymlfrom a job template into a steps template and adds a condition parameter flow intoeng/pipelines/installer/helix.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Folds installer build/test submission into existing CoreCLR/Libraries jobs; removes standalone installer jobs and artifact handoff. |
| eng/pipelines/installer/helix.yml | Adds a template parameter to gate Helix submission with an additional runtime condition. |
| eng/pipelines/installer/helix-queues-setup.yml | Refactors installer Helix queue selection into a step template that invokes the installer Helix submission template. |
|
/azp run runtime Note This CI retry command was generated by GitHub Copilot. |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Agent merge does not work well for our workflow |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
eng/pipelines/runtime.yml:330
- Installer Helix submission is currently sequenced after the libraries Helix submission in the same job. If the libraries
Send to Helixstep fails, the job will typically stop and the installer submission won’t run (previously these were separate jobs, so installer submission could still happen). Consider moving the installer submission step before the libraries submission (and applying the same reordering to the windows_x86CoreCLR_AllSubsetsblock) to reduce skipped installer coverage when Helix submission flakes.
condition: >-
or(
eq(variables['librariesContainsChange'], true),
eq(variables['isRollingBuild'], true))
- template: /eng/pipelines/installer/helix-queues-setup.yml
|
/ba-g unrelated failure: #132030 |
Summary
The standalone Installer Build and Test jobs repeat work already performed by the CoreCLR and Libraries build jobs and require an artifact handoff between jobs. Fold that work into the existing producer jobs so each platform builds and submits its installer tests in one place.
CoreCLR_AllSubsets.host+packsto the matching CoreCLR/Libraries build subsets.Testing
Parsed the changed YAML files and checked the expanded platform/configuration/suffix keys for duplicates.
Fixes #131615
Note
This pull request was prepared with GitHub Copilot.