Skip to content

Reset charsConsumed when BigInteger partial parsing fails #132278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 2 commits into from
Aug 14, 2026
+10 −0
Merged

Reset charsConsumed when BigInteger partial parsing fails #132278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e11d458
Reset charsConsumed when BigInteger partial parsing fails
tannergooding Aug 13, 2026
c8f95db
Make BigInteger partial parse tests culture-invariant
tannergooding Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libraries/System.Runtime.Numerics/src/System/Number.BigInteger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ internal static unsafe ParsingStatus TryParseBigIntegerNumber<TChar>(ReadOnlySpa
else
{
ret = NumberToBigInteger(ref number, out result);

if (ret != ParsingStatus.OK)
{
elementsConsumed = 0;
}
}
}

Expand Down
5 changes: 5 additions & 0 deletions src/libraries/System.Runtime.Numerics/tests/BigInteger/parse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,11 @@ public static IEnumerable<object[]> TryParsePartial_Invalid_TestData()
// Only invalid characters (no valid number)
yield return new object[] { "abc", NumberStyles.Integer, null };
yield return new object[] { "xyz", NumberStyles.Integer, null };

// Values that scan successfully but aren't representable as a BigInteger
yield return new object[] { "1.5", NumberStyles.Float, CultureInfo.InvariantCulture };
yield return new object[] { "3.14159abc", NumberStyles.Float, CultureInfo.InvariantCulture };
yield return new object[] { "1E1000000000", NumberStyles.Float, CultureInfo.InvariantCulture };
}

[Theory]
Expand Down