Fix assembly labels on MacOS X64 to be LOCAL_LABEL#129531
Conversation
Not doing this leads to the functions being carved up by the linker, which leads to incorrect behavior.
|
Tagging subscribers to this area: @agocke |
|
@davidwrighton what was the issue you were observing? |
|
@janvorli this was the reason for ... #128955 The linker ended up doing something remarkable. It mangled the function order and inserted padding which consisted of |
|
Oh, that's fun. Thanks for the details. |
|
/ba-g The only tests which have not passed are the Windows arm64 tests, and they won't pass due to an infra issue. |
Not doing this leads to the functions being carved up by the linker, which leads to incorrect behavior.