Skip to content

Skip System.Formats.Tar hard-link tests on platforms that can't create hard links (Android) #126316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip System.Formats.Tar hard-link tests on platforms that can't create hard links (Android) #126316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61db20b
Initial plan
Copilot Mar 30, 2026
ddb309c
Skip hard-link TAR tests on Android: add MountHelper.CanCreateHardLin…
Copilot Mar 30, 2026
d2e85d4
Merge branch 'main' into copilot/fix-permission-denied-android
rzikm Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectory.File.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ public void CreateFromDirectory_InvalidFormat_Throws(TarEntryFormat format)
TarFile.CreateFromDirectory(source.Path, destinationArchiveFileName, includeBaseDirectory: false, format));
}

[Theory]
[ConditionalTheory(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
[InlineData(true)]
[InlineData(false)]
public void CreateFromDirectory_UsesWriterOptions(bool toggle)
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectory.Stream.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public void CreateFromDirectory_InvalidFormat_Throws(TarEntryFormat format)
TarFile.CreateFromDirectory(source.Path, archive, includeBaseDirectory: false, format));
}

[Theory]
[ConditionalTheory(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
[InlineData(true)]
[InlineData(false)]
public void CreateFromDirectory_UsesWriterOptions(bool toggle)
Expand Down
2 changes: 1 addition & 1 deletion ...libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectoryAsync.File.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ await Assert.ThrowsAsync<ArgumentOutOfRangeException>("format", () =>
}
}

[Theory]
[ConditionalTheory(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
[InlineData(true)]
[InlineData(false)]
public async Task CreateFromDirectoryAsync_UsesWriterOptions(bool toggle)
Expand Down
2 changes: 1 addition & 1 deletion ...braries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectoryAsync.Stream.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ await Assert.ThrowsAsync<ArgumentOutOfRangeException>("format", () =>
}
}

[Theory]
[ConditionalTheory(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
[InlineData(true)]
[InlineData(false)]
public async Task CreateFromDirectoryAsync_UsesWriterOptions(bool toggle)
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectory.File.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public void LinkBeforeTarget()
Assert.True(File.Exists(linkPath), $"{linkPath}' does not exist.");
}

[Theory]
[ConditionalTheory(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
[InlineData(TarEntryFormat.V7, TarHardLinkMode.PreserveLink)]
[InlineData(TarEntryFormat.Ustar, TarHardLinkMode.PreserveLink)]
[InlineData(TarEntryFormat.Pax, TarHardLinkMode.PreserveLink)]
Expand Down Expand Up @@ -425,7 +425,7 @@ public void HardLinkExtractionRoundtrip(TarEntryFormat format, TarHardLinkMode l
}
}

[Fact]
[ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
public void HardLinkExtraction_CopyContents()
{
using TempDirectory root = new TempDirectory();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectoryAsync.File.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public async Task LinkBeforeTargetAsync()
Assert.True(File.Exists(linkPath), $"{linkPath}' does not exist.");
}

[Fact]
[ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
public async Task HardLinkExtraction_CopyContentsAsync()
{
using TempDirectory root = new TempDirectory();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public void Add_SymbolicLink(TarEntryFormat format, bool createTarget)
}
}

[Theory]
[ConditionalTheory(typeof(MountHelper), nameof(MountHelper.CanCreateHardLinks))]
[InlineData(TarEntryFormat.V7, TarHardLinkMode.PreserveLink)]
[InlineData(TarEntryFormat.Ustar, TarHardLinkMode.PreserveLink)]
[InlineData(TarEntryFormat.Pax, TarHardLinkMode.PreserveLink)]
Expand Down
Loading