Implement ReadSpan/WriteSpan methods in UnmanagedMemoryAccessor #118296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current UnmanagedMemoryAccessor only has the ability to read/write arrays using a slow struct marshalling loop, despite the fact that the underlying SafeBuffer now has a much more performant ReadSpan/WriteSpan implementation. This change adds a shim method to UnmanagedMemoryAccessor which allows it to read/write byte span data with a similar signature to Read/WriteArray and the performance of Span.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree company="Microsoft" (well I guess I'm not an MS employee anymore so this is just on behalf of myself) |
|
Hello, according to the process, Pull Requests that add new APIs must be opened after their approval, which means that I have to close this. Feel free to open a new PR after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS JUST A PROOF OF CONCEPT PULL REQUEST, IT DOESN'T HAVE TESTS OR ANYTHING, DON'T MERGE IN ITS CURRENT STATE
The current
UnmanagedMemoryAccessorimplementation only has the ability to read/write arrays using a slow struct marshalling loop, despite the fact that the underlyingSafeBufferalready has a much more performant ReadSpan/WriteSpan implementation. This change adds a shim method to UnmanagedMemoryAccessor which allows it to read/write byte span data, using a similar signature to Read/WriteArray but with the performance of Span.This change is specifically intended for users of MemoryMappedFiles to get the fastest performance with byte block data without requiring them to use unsafe code.
See dotnet issue #107148