-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Disable IL offset mapping validation #117809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables IL offset mapping validation in the CoreCLR VM to address failures in jitstress runs. The change is a temporary workaround to unblock testing while the underlying IL offset mapping logic is investigated and fixed.
Key changes:
- Temporarily disables IL offset mapping validation in debug builds
- Removes a duplicate assignment that was causing incorrect offset tracking
- Adds reference to the GitHub issue for context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/coreclr/vm/jitinterface.cpp | Comments out the ValidateILOffsets call with explanatory comment |
src/coreclr/vm/debugdebugger.cpp | Removes duplicate assignment of dwCurrentNativeOffset |
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
cc @dotnet/dotnet-diag, @davidwrighton, @noahfalk can you review since you looked at the original PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It it's blocking - this sounds OK. But I see only one hit?
This blocks optional pipelines that aren't tracked by build analysis. E.g. https://dev.azure.com/dnceng-public/public/_build?definitionId=109 has widespread failures from the validation asserting. |
/ba-g Helix timeout |
@davidwrighton suggested just disabling this in #117561 (comment).
Makes #117561 non blocking.
Some additional context from the case in #117561 (comment):