Skip to content

Enable linux-musl, x86, and arm cdac reader packages #117321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

steveisok
Copy link
Member

No description provided.

@steveisok steveisok requested review from Copilot and max-charlamb July 4, 2025 14:19
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables CDAC reader package builds for linux-musl, x86, and ARM by removing their previous exclusions.

  • Removes the exclusion for $(TargetsLinuxMusl) so linux-musl builds include CDAC.
  • Drops arm and x86 from the false condition, enabling those architectures.
  • Retains exclusions for source-only, armel, and riscv64 builds.

@am11 am11 added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 4, 2025
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@steveisok
Copy link
Member Author

The test part of the ios and tvos legs is hosed. Not a lack of mobile device capacity, but with the machines servicing requests.

@steveisok
Copy link
Member Author

/ba-g iOS and tvOS legs not processing any work items.

@steveisok steveisok merged commit aa37dff into dotnet:main Jul 7, 2025
141 of 151 checks passed
@steveisok steveisok deleted the more-cdac-reader-packages branch July 7, 2025 22:56
@am11
Copy link
Member

am11 commented Jul 8, 2025

This broke dev-innerloop leg which is fixed by #117397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants