-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Enable linux-musl, x86, and arm cdac reader packages #117321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables CDAC reader package builds for linux-musl, x86, and ARM by removing their previous exclusions.
- Removes the exclusion for
$(TargetsLinuxMusl)
so linux-musl builds include CDAC. - Drops
arm
andx86
from the false condition, enabling those architectures. - Retains exclusions for source-only,
armel
, andriscv64
builds.
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
The test part of the ios and tvos legs is hosed. Not a lack of mobile device capacity, but with the machines servicing requests. |
/ba-g iOS and tvOS legs not processing any work items. |
This broke dev-innerloop leg which is fixed by #117397. |
No description provided.