[cDAC] Remove native components #117024
Merged
[cDAC] Remove native components #117024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-diagnostics |
github-actions
bot
added
the
needs-area-label
|
Azure Pipelines successfully started running 1 pipeline(s). |
max-charlamb
added
area-Diagnostics-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
max-charlamb
requested review from
Copilot,
steveisok,
davidwrighton,
hoyosjs and
jkoritzinsky
There was a problem hiding this comment.
Pull Request Overview
This PR removes all cDAC-specific native unwinder components and associated build mechanics, reverting changes made for FEATURE_CDAC_UNWINDER now that cDAC no longer uses native unwinders.
- Remove DirectPInvoke and static native library linking from the cDAC csproj
- Delete the managed
Unwinder.csimplementation and its interop code - Strip out all
FEATURE_CDAC_UNWINDERconditionals from the coreclr unwinder sources and simplify CMakeLists
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/mscordaccore_universal/mscordaccore_universal.csproj | Drop static linking of unwinder libraries |
| src/native/managed/cdac/.../Unwinder.cs | Remove entire managed native-unwinder interop file |
| src/coreclr/unwinder/stdafx.h | Eliminate FEATURE_CDAC_UNWINDER include paths |
| src/coreclr/unwinder/baseunwinder.h | Remove CDACCallbacks and related guards |
| src/coreclr/unwinder/baseunwinder.cpp | Delete t_pCallbacks and conditional unwinder code |
| src/coreclr/unwinder/arm64/unwinder.h | Remove empty FEATURE_CDAC_UNWINDER blocks |
| src/coreclr/unwinder/arm64/unwinder.cpp | Strip cDAC branch, leave DacUnwindStackFrame unguarded |
| src/coreclr/unwinder/amd64/unwinder.h | Remove empty FEATURE_CDAC_UNWINDER blocks |
| src/coreclr/unwinder/amd64/unwinder.cpp | Cleanup cDAC branches, consolidate DACCESS_COMPILE guard |
| src/coreclr/unwinder/CMakeLists.txt | Remove custom cDAC targets and macros |
Comments suppressed due to low confidence (1)
src/coreclr/unwinder/arm64/unwinder.cpp:2762
- The
DacUnwindStackFramefunction is no longer wrapped in#ifdef DACCESS_COMPILE, so it will always be compiled. This can cause build failures on non-DAC builds. Wrap its definition and closing brace in#ifdef DACCESS_COMPILE ... #endif.
BOOL DacUnwindStackFrame(T_CONTEXT *pContext, T_KNONVOLATILE_CONTEXT_POINTERS* pContextPointers)
jkoritzinsky
approved these changes
Jul 7, 2025
This was referenced Jul 8, 2025
Open
hoyosjs
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #116488 and #116717, the cDAC no longer uses native unwinders.