Use RemoveAll to minimize list creation overhead #12006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rndt/removeAll # Conflicts: # src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the filtering logic by replacing the manual loop that creates a new list with a RemoveAll call to reduce list allocation overhead.
- Replaces manual filtering of ProjectItemInstance objects with a single RemoveAll call.
- Improves performance by reusing the existing list instead of creating a new one.
src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs
Show resolved
Hide resolved
rainersigwald
approved these changes
Jun 12, 2025
Updated the description with some data. |
JanProvaznik
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While this does reintroduce a capture class allocation, this is outweighed by being able to reuse the existing list since we don't need to allocate another instance as well as the internal array to hold all the items.
The savings aren't huge, but it's a pretty easy win.
Before:
After:
Looks to be a savings of ~ 6.7MB when building Roslyn.
Changes Made
Testing
Notes