Skip to content

Conversation

@rmarinho
Copy link
Member

@rmarinho rmarinho commented Nov 13, 2025

Description of Change

We need a couple of variables from this variable group.
Change other variables to control internal vs public builds.
Small cleanup

This pull request updates build and pipeline configuration files to simplify variable handling, improve conditional logic for build stages, and clean up unused parameters. The primary focus is on streamlining how build arguments and variable groups are set for different build scenarios, including official, public, and internal builds.

Build and variable configuration simplification

  • Removed the _InternalBuildArgs variable and its assignment from eng/pipelines/common/variables.yml, and updated how the MAUI variable group is included to always be present, rather than conditionally. [1] [2]
  • Changed the logic for setting _PublishArgs in eng/pipelines/arcade/variables.yml to use build definition names instead of checking for public/internal builds and pull requests, making the conditions more explicit and maintainable.
  • Set _OfficialBuildIdArgs to an empty value instead of passing parameters, simplifying the official build argument handling.

Pipeline cleanup and conditional logic improvements

  • Removed the unused UseProvisionator parameter and related provisioning logic from eng/pipelines/ci-uitests.yml, reducing complexity and potential confusion in test pipeline configuration. [1] [2]

Minor fix

  • Updated the Creator property condition in eng/helix.proj to check for an existing value before setting a default, preventing unwanted overrides.

Copilot AI review requested due to automatic review settings November 13, 2025 22:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the variable group declarations in the pipeline configuration to make the MAUI variable group unconditionally available instead of being conditionally included based on build definition names.

Key Changes

  • The MAUI variable group is moved from conditional inclusion to unconditional inclusion at the top level

@rmarinho rmarinho merged commit f7587ec into main Nov 17, 2025
177 of 195 checks passed
@rmarinho rmarinho deleted the fix-uitests-pipeline branch November 17, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants