Skip to content

bump: PreReleaseVersionIteration 10 → 11#329

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/update-preview-version-to-11
Open

bump: PreReleaseVersionIteration 10 → 11#329
Copilot wants to merge 2 commits into
mainfrom
copilot/update-preview-version-to-11

Conversation

Copilot AI commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Bumps the repo's package preview iteration from 10 to 11 so all shipped packages version as 0.1.0-preview.11.<build> going forward.

Change

  • eng/Versions.propsPreReleaseVersionIteration: 1011

This is the single authoritative location; Arcade's build pipeline derives the pre-release suffix from it automatically.

Not changed (intentionally)

  • global.json / SDK pin — still .NET 10; unrelated to the preview iteration label
  • Comet/Go .NET 11 tooling — separate product versioning, out of scope
  • DevFlowSkillManagerTests.cs — the "0.1.0-preview.10" inline data tests version-comparison parsing logic, not a pinned version assumption

Co-authored-by: rmarinho <1235097+rmarinho@users.noreply.github.com>
Copilot AI changed the title [WIP] Update preview version to .NET 11 bump: PreReleaseVersionIteration 10 → 11 Jun 15, 2026
Copilot AI requested a review from rmarinho June 15, 2026 16:45
@rmarinho rmarinho requested a review from jfversluis June 15, 2026 17:31
@rmarinho rmarinho marked this pull request as ready for review June 15, 2026 17:31
@rmarinho rmarinho self-requested a review June 15, 2026 17:32
@rmarinho rmarinho self-requested a review June 16, 2026 11:28
@github-actions

Copy link
Copy Markdown
Contributor

Expert Code Review — PR #329

Methodology: 3 independent reviewers with adversarial consensus

Result: No issues reached consensus ✅

All 3 reviewers analyzed this single-line version bump (PreReleaseVersionIteration: 10 → 11 in eng/Versions.props). Two reviewers found no issues; one raised a concern that was evaluated and discarded.

Discarded findings

# Severity Reviewer Finding Reason discarded
1 🟡 MODERATE Reviewer 3 PR description says "all shipped packages" but platform backends and Essentials.AI use independent versioning and won't become 0.1.0-preview.11 1/3 consensus only — follow-up reviewer disagreed, noting this is a PR description editorial concern, not a code defect. The code change itself is correct.

CI Status

✅ All CI checks passing (39/39 completed successfully across macOS, Windows, Ubuntu). 1 check in-progress (this review workflow).

Test Coverage

No tests are needed for this change — it's a declarative version property consumed by the Arcade SDK build infrastructure. The PR correctly notes that DevFlowSkillManagerTests.cs uses "0.1.0-preview.10" as arbitrary test data for version-comparison logic, not a pinned version assumption.


Generated by Expert Code Review · 3 independent reviewers with adversarial consensus

Generated by Expert Code Review (auto) for issue #329 · ● 4.2M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants