feat(fcs): expose FSharpMemberOrFunctionOrValue.IsPropertyAccessor#19883
Open
T-Gro wants to merge 5 commits into
Open
feat(fcs): expose FSharpMemberOrFunctionOrValue.IsPropertyAccessor#19883T-Gro wants to merge 5 commits into
T-Gro wants to merge 5 commits into
Conversation
…roperty (issue #18157) These tests do not yet compile - the API member is added in the next commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…18157) Adds a convenience property that returns true when the MFV represents a compiler-generated property accessor (get_X or set_X). Implemented as a disjunction of the existing IsPropertyGetterMethod / IsPropertySetterMethod so behaviour is identical across both F#-declared and imported .NET members. Surface-area baseline updated. Sprint 01 tests adjusted to use getParseAndCheckResults + GetAllUsesOfAllSymbolsInFile so they actually exercise the new API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auduchinok
reviewed
Jun 2, 2026
| | V v -> v.IsPropertySetterMethod | ||
| | _ -> false | ||
|
|
||
| member x.IsAccessorProperty = |
Member
There was a problem hiding this comment.
It should be IsPropertyAccessor I think?
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
Address review feedback from @auduchinok: rename the member to IsPropertyAccessor for consistency with existing naming conventions (IsPropertyGetterMethod, IsPropertySetterMethod). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
Member
Author
|
@copilot : Rename all occurrences to |
Contributor
Copilot
AI
changed the title
feat(fcs): expose FSharpMemberOrFunctionOrValue.IsAccessorProperty
feat(fcs): expose FSharpMemberOrFunctionOrValue.IsPropertyAccessor
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
FSharpMemberOrFunctionOrValue.IsPropertyAccessor— a convenience property that returns true when the symbol represents a compiler-generated property accessor (get_X or set_X).Implementation
Implemented as a simple disjunction of the existing
IsPropertyGetterMethod/IsPropertySetterMethodso behaviour is identical across both F#-declared and imported .NET members.