Skip to content

fix: throw InvalidOperationException when MarkItDownMcpReader encounters IsError. #7627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaleemsolutions wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: throw InvalidOperationException when MarkItDownMcpReader encounters IsError. #7627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e31d6
fix: throw InvalidOperationException when MarkItDownMcpReader encount…
a4abdulaleem Jul 14, 2026
fdf893f
fix: handle nullable bool and fix analyzer formatting rules
a4abdulaleem Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Libraries/Microsoft.Extensions.DataIngestion.MarkItDown/MarkItDownMcpReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,27 @@ private async Task<string> ConvertToMarkdownAsync(DataContent dataContent, Cance
// Call the convert_to_markdown tool
var result = await client.CallToolAsync("convert_to_markdown", parameters, cancellationToken: cancellationToken).ConfigureAwait(false);

// FIX: Check if the tool execution returned an error (handles bool?)
if (result.IsError == true)
Comment on lines +92 to +93

@jeffhandley jeffhandley Aug 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code comment shouldn't have "FIX: " in it and the "(handles bool?)" is a bit confusing on first glance. The comment is actually superfluous anyway.

Suggested change
// FIX: Check if the tool execution returned an error (handles bool?)
if (result.IsError == true)
if (result.IsError == true)

{
// Extract the error message from the content block if available, or fall back to a default error
string errorText = "An unknown error occurred during document conversion.";

if (result.Content != null && result.Content.Count > 0)
{
foreach (var content in result.Content)
{
if (content.Type == "text" && content is TextContentBlock textBlock)
{
errorText = textBlock.Text;
break;
}
}
}

throw new InvalidOperationException($"Failed to convert document to markdown: {errorText}");
}

// Extract markdown content from result
// The result is expected to be in the format: { "content": [{ "type": "text", "text": "markdown content" }] }
if (result.Content != null && result.Content.Count > 0)
Expand Down
Loading