Fix compiled-model CreateRelationalModel() failure when an owned entity shares its owner's table by Copilot · Pull Request #38428 · dotnet/efcore

Copilot · 2026-06-13T00:46:29Z

A compiled model whose owned entity shares its owner's table (where the owner has an index/constraint) threw System.InvalidOperationException: Sequence contains no elements from CreateRelationalModel() at runtime, despite compiling successfully.

Root cause

RelationalCSharpRuntimeAnnotationCodeGenerator emitted unique-constraint/index/trigger creation inline, guarded by tableMapping == table.EntityTypeMappings.Last(). When an owned entity (e.g. Author) shares its owner's (Post) table and its mapping is the last EntityTypeMapping but is iterated before the owner, an index (e.g. IX_Posts_BlogId) was generated before the referenced column's mapping existed. SetRowIndexValueFactory(...) then hit ColumnBase.GetDefaultStoreTypeMapping(), which requires at least one column mapping — hence the empty-sequence failure.

Changes

RelationalCSharpRuntimeAnnotationCodeGenerator: moved unique-constraint, index, and trigger emission out of the per-ITableMapping path into a CreateTableConstraints pass over model.Tables, run after all column mappings are emitted, guaranteeing every referenced column is mapped before constraints/indexes are built.
Ordering: foreign keys remain in a separate model.Tables pass after CreateTableConstraints. Generated FKs resolve their principal's unique constraint at runtime via principalTable.FindUniqueConstraint(name)!, and IRelationalModel.Tables is not topologically ordered — so all unique constraints must be emitted before any FK. The foreignKeysOnly parameter was removed; the FK loop is inlined.
Tests: added the Owned_entity_sharing_table_with_owner_that_has_an_index regression test (Blog/Post/Author).
Baselines: added Sqlite/SqlServer baselines for the new test and regenerated affected existing baselines (BigModel_with_JSON_columns, ComplexTypes, Tpc_Sprocs) — pure relocations of constraint/index emission after column mappings.

Generated code, before vs after

// before: index emitted while processing Author's (last) mapping — blogIdColumn has no mapping yet
var iX_Posts_BlogId = new TableIndex("IX_Posts_BlogId", postsTable, new[] { blogIdColumn }, false);
iX_Posts_BlogId.SetRowIndexValueFactory(new SimpleRowIndexValueFactory<int>(iX_Posts_BlogId)); // throws
...
RelationalModel.CreateColumnMapping(blogIdColumn, post.FindProperty("BlogId")!, postsTableMapping0);

// after: all column mappings first, then constraints/indexes in the post-pass
RelationalModel.CreateColumnMapping(blogIdColumn, post.FindProperty("BlogId")!, postsTableMapping0);
...
var iX_Posts_BlogId = new TableIndex("IX_Posts_BlogId", postsTable, new[] { blogIdColumn }, false);
iX_Posts_BlogId.SetRowIndexValueFactory(new SimpleRowIndexValueFactory<int>(iX_Posts_BlogId));

…owner's table Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot

Pull request overview

Fixes a runtime failure when creating the relational model from a compiled model in scenarios where an owned entity shares its owner’s table and the owner has an index/constraint. The fix ensures table constraints/indexes/triggers are generated only after all column mappings exist, preventing empty-sequence failures during value-factory setup.

Changes:

Updated RelationalCSharpRuntimeAnnotationCodeGenerator to generate unique constraints, indexes, and triggers in a dedicated post-pass over model.Tables, after all column mappings are emitted (and before FK constraints).
Added a regression test (Owned_entity_sharing_table_with_owner_that_has_an_index) to force relational-model creation in the problematic mapping order and validate index presence.
Regenerated/updated compiled-model scaffolding baselines (primarily reordering constraint/index emission after mappings) and added new Sqlite/SqlServer baselines for the new test.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/EFCore.Relational/Design/Internal/RelationalCSharpRuntimeAnnotationCodeGenerator.cs	Moves table constraint/index/trigger emission to a table-level post-pass after column mappings are generated.
test/EFCore.Relational.Specification.Tests/Scaffolding/CompiledModelRelationalTestBase.cs	Adds regression test and supporting `Blog`/`Post`/`Author` types for the owned-shared-table + index scenario.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Tpc_Sprocs/DbContextModelBuilder.cs	Baseline update reflecting reordered constraint/index emission.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/ComplexTypes/DbContextModelBuilder.cs	Baseline update reflecting reordered constraint/index emission.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DbContextModelBuilder.cs	Baseline update reflecting reordered constraint/index emission.
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DbContextModelBuilder.cs	Baseline update reflecting reordered constraint/index emission.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextAssemblyAttributes.cs	New baseline assembly attributes for the SqlServer provider.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextModel.cs	New baseline runtime model for the SqlServer provider.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextModelBuilder.cs	New baseline relational model builder output for the SqlServer provider.
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/BlogEntityType.cs	New baseline entity type for `Blog` (SqlServer).
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/BlogUnsafeAccessors.cs	New baseline unsafe accessors for `Blog` (SqlServer).
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/PostEntityType.cs	New baseline entity type for `Post` (SqlServer).
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/PostUnsafeAccessors.cs	New baseline unsafe accessors for `Post` (SqlServer).
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/AuthorEntityType.cs	New baseline entity type for owned `Author` (SqlServer).
test/EFCore.SqlServer.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/AuthorUnsafeAccessors.cs	New baseline unsafe accessors for `Author` (SqlServer).
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextAssemblyAttributes.cs	New baseline assembly attributes for the Sqlite provider.
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextModel.cs	New baseline runtime model for the Sqlite provider.
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextModelBuilder.cs	New baseline relational model builder output for the Sqlite provider.
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/BlogEntityType.cs	New baseline entity type for `Blog` (Sqlite).
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/BlogUnsafeAccessors.cs	New baseline unsafe accessors for `Blog` (Sqlite).
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/PostEntityType.cs	New baseline entity type for `Post` (Sqlite).
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/PostUnsafeAccessors.cs	New baseline unsafe accessors for `Post` (Sqlite).
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/AuthorEntityType.cs	New baseline entity type for owned `Author` (Sqlite).
test/EFCore.Sqlite.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/AuthorUnsafeAccessors.cs	New baseline unsafe accessors for `Author` (Sqlite).

AndriySvyryd · 2026-06-13T04:28:26Z

                foreach (var foreignKey in table.ForeignKeyConstraints)
                {
                    Create(foreignKey, parameters with { TargetName = parameters.ScopeVariables[table] });
                }


@copilot Move this into CreateTableConstraints too

Addressed in 0b6de21 (follow-up naming cleanup in 5f25063). The foreign-key pass is now routed through CreateTableConstraints(...) as requested.

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

AndriySvyryd · 2026-06-15T22:53:47Z

            foreach (var table in model.Tables)
            {
-                foreach (var foreignKey in table.ForeignKeyConstraints)
-                {
-                    Create(foreignKey, parameters with { TargetName = parameters.ScopeVariables[table] });
-                }
+                CreateTableConstraints(table, relationalModelParameters);
+            }
+
+            foreach (var table in model.Tables)
+            {
+                CreateTableConstraints(table, relationalModelParameters, foreignKeysOnly: true);
            }


@copilot Collapse these loops and remove foreignKeysOnly parameter. Update baselines

Removed the foreignKeysOnly parameter — the FK pass is now inlined directly in CreateRelationalModel (matching the pre-existing style for the other table loops).

I kept the foreign keys in a separate model.Tables loop rather than collapsing the two into one, because a single interleaved pass breaks at runtime. Each generated foreign key resolves its principal's unique constraint eagerly via principalTable.FindUniqueConstraint(name)!, so every unique constraint must already be emitted before any foreign key runs. IRelationalModel.Tables is insertion/alphabetically ordered (Dictionary<(string, string?), Table>), not topologically ordered, so when a dependent table is processed before its principal, FindUniqueConstraint returns null and CreateRelationalModel() throws NullReferenceException.

I reproduced this concretely: collapsing into one loop makes CompiledModelSqliteTest.BigModel_with_JSON_columns throw NullReferenceException from GetRelationalModel() (e.g. dependentBase's FK referencing principalBase.FindUniqueConstraint("AK_PrincipalBase_Id") before principalBase's constraints are added). Keeping the FK pass after the unique-constraint/index/trigger pass keeps it green.

Because the relative emission order is unchanged, no baselines needed updating. Let me know if you'd prefer a different structure (e.g. a dedicated CreateForeignKeyConstraints method) or if you'd like me to pursue topologically ordering the tables instead.

@copilot Ok, then revert the fk generation code and separate it. Add a comment explaining why it's a different loop

Done in c814f17. Reverted the FK generation back to the original Create(foreignKey, parameters with { TargetName = parameters.ScopeVariables[table] }) call, kept it as a separate model.Tables loop, and added a comment explaining that it runs after the unique-constraint pass because each FK resolves the principal table's unique constraint, which may belong to a table processed later above. Generated output is unchanged, so no baselines needed updating.

Correction: the commit is 6895dee (not c814f17).

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

…atory comment Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Initial plan

131bb5d

Copilot AI assigned Copilot and AndriySvyryd Jun 13, 2026

Copilot started work on behalf of AndriySvyryd June 13, 2026 00:47 View session

Fix compiled model CreateRelationalModel() with owned entity sharing …

2e80c83

…owner's table Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix CreateRelationalModel() to handle owned entities~~ Fix compiled model CreateRelationalModel() failure with owned entity sharing owner's table Jun 13, 2026

Copilot finished work on behalf of AndriySvyryd June 13, 2026 01:25

Copilot AI requested a review from AndriySvyryd June 13, 2026 01:25

AndriySvyryd requested a review from Copilot June 13, 2026 04:25

Copilot started reviewing on behalf of AndriySvyryd June 13, 2026 04:25 View session

Copilot AI reviewed Jun 13, 2026

View reviewed changes

AndriySvyryd reviewed Jun 13, 2026

View reviewed changes

Copilot started work on behalf of AndriySvyryd June 13, 2026 04:29 View session

Copilot AI and others added 2 commits June 13, 2026 04:36

Refactor foreign key table pass into CreateTableConstraints

0b6de21

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Clarify CreateTableConstraints foreign-key-only pass

5f25063

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot finished work on behalf of AndriySvyryd June 13, 2026 04:37

Copilot AI requested a review from AndriySvyryd June 13, 2026 04:37

AndriySvyryd reviewed Jun 15, 2026

View reviewed changes

Copilot stopped work on behalf of AndriySvyryd due to an error June 15, 2026 22:54
The "Initialize containers" custom setup step from your .github/workflows/copilot-setup-steps.yml file failed.

Copilot AI requested a review from AndriySvyryd June 15, 2026 22:54

Copilot started work on behalf of AndriySvyryd June 16, 2026 00:27 View session

Remove foreignKeysOnly parameter from CreateTableConstraints

c0cdb06

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot AI changed the title ~~Fix compiled model CreateRelationalModel() failure with owned entity sharing owner's table~~ Fix compiled-model CreateRelationalModel() failure when an owned entity shares its owner's table Jun 16, 2026

Copilot finished work on behalf of AndriySvyryd June 16, 2026 00:50

Copilot started work on behalf of AndriySvyryd June 16, 2026 02:55 View session

Revert FK generation to original form, keep separate loop with explan…

6895dee

…atory comment Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot finished work on behalf of AndriySvyryd June 16, 2026 03:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compiled-model CreateRelationalModel() failure when an owned entity shares its owner's table#38428

Fix compiled-model CreateRelationalModel() failure when an owned entity shares its owner's table#38428
Copilot wants to merge 6 commits into
mainfrom
copilot/fix-create-relational-model-error

Copilot AI commented Jun 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

AndriySvyryd Jun 13, 2026

Uh oh!

Copilot AI Jun 13, 2026

Uh oh!

AndriySvyryd Jun 15, 2026

Uh oh!

Copilot AI Jun 16, 2026

Uh oh!

AndriySvyryd Jun 16, 2026

Uh oh!

Copilot AI Jun 16, 2026

Uh oh!

Copilot AI Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root cause

Changes

Generated code, before vs after

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

AndriySvyryd Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

AndriySvyryd Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

AndriySvyryd Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jun 13, 2026 •

edited

Loading